Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM
driver.
CC: linuxppc-dev@ozlabs.org
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Index: linux-2.6.24-git12-pata2/arch/ppc/Kconfig
===================================================================
--- linux-2.6.24-git12-pata2.orig/arch/ppc/Kconfig
+++ linux-2.6.24-git12-pata2/arch/ppc/Kconfig
@@ -41,6 +41,7 @@ config GENERIC_CALIBRATE_DELAY
config PPC
bool
+ select HAVE_PATA_PLATFORM
default y
config PPC32
Index: linux-2.6.24-git12-pata2/drivers/ata/Kconfig
===================================================================
--- linux-2.6.24-git12-pata2.orig/drivers/ata/Kconfig
+++ linux-2.6.24-git12-pata2/drivers/ata/Kconfig
@@ -624,7 +624,7 @@ config HAVE_PATA_PLATFORM
config PATA_PLATFORM
tristate "Generic platform device PATA support"
- depends on EMBEDDED || PPC || HAVE_PATA_PLATFORM
+ depends on EMBEDDED || HAVE_PATA_PLATFORM
help
This option enables support for generic directly connected ATA
devices commonly found on embedded systems.
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
On Sat, Feb 02, 2008 at 04:21:36PM +0000, Ben Dooks wrote:
Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM
driver.
CC: linuxppc-dev@ozlabs.org
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
What tree is this against? It doesn't apply to current mainline nor
jgarzik's libata-dev upstream branch.
Anyway: NACK: I like this approach but this needs to be added to
arch/powerpc as well.
It's actually more needed there than arch/ppc, I don't personally care
if arch/ppc can't use pata_platform for the last couple of months it's
still around (it's getting deleted this summer, all platforms should
have moved to powerpc by then).
-Olof
On Sat, Feb 02, 2008 at 01:12:39PM -0600, Olof Johansson wrote:
On Sat, Feb 02, 2008 at 04:21:36PM +0000, Ben Dooks wrote:
quoted
Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM
driver.
CC: linuxppc-dev@ozlabs.org
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
What tree is this against? It doesn't apply to current mainline nor
jgarzik's libata-dev upstream branch.
It is a series that i've just sent to the linux-ide list, only the ppc
part was cc'd to the ppc list.
Anyway: NACK: I like this approach but this needs to be added to
arch/powerpc as well.
I can add that to the series.
It's actually more needed there than arch/ppc, I don't personally care
if arch/ppc can't use pata_platform for the last couple of months it's
still around (it's getting deleted this summer, all platforms should
have moved to powerpc by then).
Thanks, didn't know that.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
On Sat, Feb 02, 2008 at 07:41:02PM +0000, Ben Dooks wrote:
On Sat, Feb 02, 2008 at 01:12:39PM -0600, Olof Johansson wrote:
quoted
On Sat, Feb 02, 2008 at 04:21:36PM +0000, Ben Dooks wrote:
quoted
Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM
driver.
CC: linuxppc-dev@ozlabs.org
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
What tree is this against? It doesn't apply to current mainline nor
jgarzik's libata-dev upstream branch.
It is a series that i've just sent to the linux-ide list, only the ppc
part was cc'd to the ppc list.
D'oh. Ok, makes more sense now.
Are you planning on adding HAVE_PATA_PLATFORM to the other archs that
use it as well, or keep it under EMBEDDED there?
quoted
Anyway: NACK: I like this approach but this needs to be added to
arch/powerpc as well.
I can add that to the series.
Ok, cool. We can probably move it in under the relevant powerpc
sub-platforms over time, and that's a powerpc-specific change anyway,
no need to get that through linux-ide.
quoted
It's actually more needed there than arch/ppc, I don't personally care
if arch/ppc can't use pata_platform for the last couple of months it's
still around (it's getting deleted this summer, all platforms should
have moved to powerpc by then).
Thanks, didn't know that.
No problem. :)
-Olof