Re: [PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index
From: Jeff Garzik <hidden>
Date: 2008-02-01 17:53:01
Also in:
linux-serial, netdev
Anton Vorontsov wrote:
On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote:quoted
On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote:quoted
It isn't used anywhere, so remove it. If we'll ever need something like this, we'll use compatible property instead. Signed-off-by: Anton Vorontsov <redacted> --- Rebased on top of recent tree. Documentation/powerpc/booting-without-of.txt | 1 - arch/powerpc/boot/dts/mpc832x_mds.dts | 3 --- arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 -- arch/powerpc/boot/dts/mpc836x_mds.dts | 2 -- arch/powerpc/boot/dts/mpc8568mds.dts | 2 -- 5 files changed, 0 insertions(+), 10 deletions(-)diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt index 410c847..dcf9758 100644--- a/Documentation/powerpc/booting-without-of.txt +++ b/Documentation/powerpc/booting-without-of.txt@@ -1675,7 +1675,6 @@ platforms are moved over to use the flattened-device-tree model. ucc@2000 { device_type = "network"; compatible = "ucc_geth"; - model = "UCC"; device-id = <1>;can we change device-id to cell-index?Sure. But let's do this in the separate patch? Because this change actually touches the code in the two subsystems: net and serial. I hope everybody will agree to pass it through powerpc tree..? - - - - From: Anton Vorontsov <redacted> Subject: [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index device-id is worse than cell-index. Probably cell-index isn't good either, but device-id is worse anyway. Drivers are modified for backward compatibility's sake. Signed-off-by: Anton Vorontsov <redacted> --- Documentation/powerpc/booting-without-of.txt | 4 ++-- arch/powerpc/boot/dts/mpc832x_mds.dts | 4 +--- arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 -- arch/powerpc/boot/dts/mpc836x_mds.dts | 2 -- arch/powerpc/boot/dts/mpc836x_rdk.dts | 12 ++++++------ arch/powerpc/boot/dts/mpc8568mds.dts | 2 -- drivers/net/ucc_geth.c | 8 +++++++- drivers/net/ucc_geth_mii.c | 11 ++++++++--- drivers/serial/ucc_uart.c | 16 ++++++++++++---- 9 files changed, 36 insertions(+), 25 deletions(-)
ACK drivers/net