RE: [PATCH] [POWERPC] Xilinx: hwicap driver

Thanks,

I realized that on the way home..  That's what I get for trying to
finish something quickly before leaving.. :)

Steve

-----Original Message-----
From: Nathan Lynch [mailto:ntl@pobox.com]
Sent: Thursday, January 31, 2008 9:56 PM
To: Stephen Neuendorffer
Cc: linuxppc-dev@ozlabs.org; grant.likely@secretlab.ca;

jacmet@sunsite.dk

Subject: Re: [PATCH] [POWERPC] Xilinx: hwicap driver
=20
Stephen Neuendorffer wrote:

quoted

+static ssize_t
+hwicap_read(struct file *file, char *buf, size_t count, loff_t

*ppos)

quoted

+{
+	struct hwicap_drvdata *drvdata =3D file->private_data;
+	ssize_t bytes_to_read =3D 0;
+	u32 *kbuf;
+	u32 words;
+	u32 bytes_remaining;
+	int status;
+
+        spin_lock(&hwicap_spinlock);
+	if (drvdata->is_accessing)
+		return -EBUSY;

=20
Need to unlock before returning (several places in this patch).
=20