Andy,

/drivers/net/fec_8xx

Doesn't use the call, though I imagine it is legacy or only for older
boards.

Thanks for pointing me at the newer stuff, guess I had a brain cramp and
didn't think to look there. Also makes much more sense now that the 
pdev->dev is not a PCI device but a Platform device.

One question, since you've probably got more experience with this than I do.

The gianfar, and ucc_geth drivers are not modules. Is there a problem with
using these driver _probe_ functions in a module style driver? OR should I
just change my driver over to be a platform style?

As far as I can tell the HDLC driver I am trying to create for the 83xx is
going to be somewhat similar to the Ethernet driver. Only I don't want it
loaded as part of the kernel.

-Russ

-----Original Message-----
From: Andy Fleming [mailto:afleming@freescale.com]
Sent: Tuesday, January 29, 2008 2:33 PM
To: rmcguire@videopresence.com
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: SET_NETDEV_DEV -> 83xx HDLC Driver??


On Jan 25, 2008, at 20:43, Russell McGuire wrote:

quoted

All,

I am partly done porting a combination of the 83xx ATM driver and
dscc4 HDLC
driver into a 83xx HDLC driver.

However, encounter a call I don't truly understand.

SET_NETDEV_DEV(dev, pointer_to_some_handle);

I can see plenty of examples of this registering some kind of PCI
device
handle, however in this case I am not using a PCI device. So what
should the
pointer be? Or can this call be ignored, and if so what are the
consequences?

I see the some of the Freescale Ethernet devices don't use this call.

Anyway, can somebody shed some light on if I am going to need this,
or a way
to get it to work, without creating a PCI device?

Look at gianfar.c (which uses a platform_device) or ucc_geth (which
uses an of_device).  Which freescale devices don't use that call?
We'll fix them.

Andy