Re: [RFC/PATCH 1/2] [POWERPC] mpc5200: normalize compatible property bindings
From: Stephen Rothwell <hidden>
Date: 2008-01-19 12:34:26
Hi Grant, On Fri, 18 Jan 2008 10:04:49 -0700 Grant Likely [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+++ b/arch/powerpc/platforms/52xx/lite5200.c@@ -44,9 +44,14 @@ lite5200_fix_clock_config(void) { struct device_node *np; struct mpc52xx_cdm __iomem *cdm; + struct of_device_id cdm_ids[] = {
Surely this should be static and __initdata?
quoted hunk ↗ jump to hunk
@@ -79,9 +84,14 @@ lite5200_fix_port_config(void) { struct device_node *np; struct mpc52xx_gpio __iomem *gpio; + struct of_device_id gpio_ids[] = {
And this?
quoted hunk ↗ jump to hunk
+++ b/arch/powerpc/platforms/52xx/lite5200_pm.c@@ -43,6 +43,12 @@ static int lite5200_pm_set_target(suspend_state_t state) static int lite5200_pm_prepare(void) { struct device_node *np; + struct of_device_id immr_ids[] = {
This should be static and const. Similarly for the rest ... -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Attachments
- (unnamed) [application/pgp-signature] 189 bytes