Re: [PATCH] [POWERPC] Update TQM5200, CM5200 and Motion-PRO _defconfig and .dts files

On Thu, Jan 17, 2008 at 11:05:12PM +0100, Marian Balakowicz wrote:

Grant Likely wrote:

quoted

On 1/17/08, Marian Balakowicz [off-list ref] wrote:

quoted

Grant Likely wrote:

quoted

On 1/17/08, Marian Balakowicz [off-list ref] wrote:

...

quoted

quoted

quoted

Can you split the defconfig changes into a separate patch...  That
being said, how do you feel about merging all the 5200 defconfigs into
a single defconfig?  They are all multiplatform after all and it would
make maintenance easier.

Ok, I'll split it into two patches.

But merging defconfigs won't be a good option, boards differ in which
devices they use, some have PCI, some have USB, etc. Having one
defconfig, it would be necessary to manually customize kernel
configuration and remember which options are to be set/disabled.

That doesn't matter for defconfigs.  That needs to be done when you're
tailoring a product regardless.  defconfigs are simply a known good
configuration; they are not intended to be the deployed config.  If
the defconfig enables all features used by any of the boards then it
should be okay.

That's true, defconfigs are only reference configurations, but still,
I would opt for a separate defconfigs as it is more clear which target
given defconfig is meant for and it is more convenient for development
and customer to have it separate. And IMHO it's actually easier to
maintain, as you don't need to consider all three boards each time you
update defconfig and don't need to test each defconfig change on three
(right now) boards, etc.

I disagree, I have one defconfig for all our boards to date. It means I
only have one kernel to build to test on all boards, instead of having
to build a number of different kernels. Keeping it fairly generic also
means a customer can start out using the generic kernel in case they
want to, and later on add their own drivers and prune out what is not
needed.


-Olof