RE: [PATCH] Fix remainder calculating bug in single floating pointdivision
From: Liu Yu <hidden>
Date: 2008-01-09 15:38:38
-----Original Message----- From: linuxppc-dev-bounces+b13201=3Dfreescale.com@ozlabs.org=20 [mailto:linuxppc-dev-bounces+b13201=3Dfreescale.com@ozlabs.org]=20 On Behalf Of Kumar Gala Sent: Tuesday, January 08, 2008 2:20 PM To: Dan Malek Cc: Liu Yu; linuxppc-dev@ozlabs.org Subject: Re: [PATCH] Fix remainder calculating bug in single=20 floating pointdivision =20 =20 On Jan 6, 2008, at 2:44 PM, Dan Malek wrote: =20quoted
On Jan 6, 2008, at 12:07 PM, Benjamin Herrenschmidt wrote:quoted
It's nice to see somebody digging in that scary math emu stuff. If=20 you could also get rid of the warnings, it would be perfect :-)Yes, it is :-) I didn't think it would have a life beyond MPC8xx.quoted
.... that this code was lifted from somewhere else (glibc ? gcc soft-float ?),It seems like a lifetime ago.... I copied the framework=20from Sparc,=20quoted
and the internals from gcc soft-float. I didn't change any of the=20 internal emulation functions (hence, some of the warnings),=20just the=20quoted
calling interface. While it's convenient, I still don't think kernel float emulation=20 should be a solution. The tools should generate soft-float for the=20 applications and libraries.=20 If we think this is really true, we could move to using include/math- emu/* instead of the files in powerpc/math-emu.
Why it's better to move to using include/math-emu. I found they have similar framework, is powerpc/math-emu evolved from include/math-emu?
=20 The problem I had was when I tried to recreate the history of=20 the code in powerpc/math-emu and how it doesn't really match=20 the glibc code base. There are some differences and I wasn't=20 sure if they were do to trying to match PPC HW at a bit level or not. =20 I was hoping that the work Liu Yu would get as a bit of a=20 testsuite to see if there was any harm in moving over to=20 include/math-emu. =20 - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev =20