Thread (5 messages) flat view 5 messages, 3 authors, 2008-01-08

Re: [PATCH v6] qe: add ability to upload QE firmware

From: Timur Tabi <hidden>
Date: 2008-01-08 15:29:33

Stephen Rothwell wrote:
Why not:
	const u64 *iprop;
	int len;

	iprop = of_get_property(fs, "extended-modes", &len);
	if (iprop && (len == sizeof(u64))
		qe_firmware_info.extended_modes = *iprop;
Actually, I like my way better, because then I don't have to define 'len', and I 
don't have to define two integer property variables one for u32 and one for u64. 
  Besides, now that I'm at version 6, I'd rather not post updates for minor 
stylistic changes.

-- 
Timur Tabi
Linux kernel developer at Freescale
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help