On Wed, Jan 02, 2008 at 10:42:08PM +1100, David Gibson wrote:

On Fri, Dec 21, 2007 at 03:29:22PM -0600, Olof Johansson wrote:

quoted

Hi,

On Fri, Dec 21, 2007 at 01:21:30PM +1100, David Gibson wrote:

quoted

Index: working-2.6/arch/powerpc/platforms/Kconfig
===================================================================

--- working-2.6.orig/arch/powerpc/platforms/Kconfig	2007-12-10 10:52:44.000000000 +1100
+++ working-2.6/arch/powerpc/platforms/Kconfig	2007-12-21 13:11:34.000000000 +1100

@@ -315,6 +315,9 @@ config FSL_ULI1575
 config CPM
 	bool
 
+config OF_RTC
+	bool
+

New config options should have descriptions, even if they're silent
ones.

Uh.. but if there's a description, won't kconfig prompt for the
option?  This one should only ever be selected by the platform
options.

Sorry, should have said "should have help texts to describe them". Yes,
the one-line description will trigger a question, but adding a short
help text describing what the config option is for does not.


-Olof