Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c
From: Josh Boyer <hidden>
Date: 2008-01-24 01:20:31
Also in:
lkml
On Wed, 23 Jan 2008 23:37:33 +0100 Roel Kluin [off-list ref] wrote:
quoted hunk ↗ jump to hunk
logical/bitand typo Signed-off-by: Roel Kluin <redacted> ---diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c index ebf9e21..dcfb459 100644 --- a/arch/powerpc/boot/4xx.c +++ b/arch/powerpc/boot/4xx.c@@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void) val = DDR_GET_VAL(val, DDR_CS_MAP, DDR_CS_MAP_SHIFT); cs = 0; while (val) { - if (val && 0x1) + if (val & 0x1) cs++; val = val >> 1; }
Hm, good catch. Stefan, have you had problems with this code at all? josh