Thread (5 messages) flat view 5 messages, 5 authors, 2007-12-17

Re: [PATCH 2/3] arch/ : Platform changes for UCC TDM driver for MPC8323ERDB.Also includes related QE changes.

From: Poonam Aggrwal <hidden>
Date: 2007-12-17 05:40:57

Thanx Tabi for your comments.
Sorry I was on leave for the last week, so could not reply in time.

Shall make the changes you suggested and repost the patch.

Regards
Poonam



On 12/11/07, Timur Tabi [off-list ref] wrote:
Poonam_Aggrwal-b10812 wrote:
quoted
+                     qe = of_find_node_by_type(NULL, "qe");
+                     if (qe) {
+                             unsigned int size;
+                             prop = of_get_property
+                                             (qe, "brg-frequency",
&size);
quoted
+                             of_node_put(qe);
+                             of_node_put(brg);
+                             return *prop;
+                     }
Only very recent versions of U-Boot set the brg-frequency property, so you
need
to check for situations where "*prop" is 0.  If it is, then you need to
take the
QE's bus-frequency property and divide it by two.  See my ucc_uart driver
for an
example.

And PowerPC-specific patches should not be cross-posted to linux-kernel.

--
Timur Tabi
Linux kernel developer at Freescale
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help