Re: [RFC/PATCH 5/10] powerpc: pci32: Remove obsolete PowerMac bus number hack
From: Jon Loeliger <hidden>
Date: 2007-12-06 17:03:15
On Thu, 2007-12-06 at 02:11, Benjamin Herrenschmidt wrote:
quoted hunk ↗ jump to hunk
The 32 bits PCI code carries an old hack that was only useful for G5 machines. Nowdays, the 32 bits kernel doesn't support any of those machines anymore so the hack is basically never used, remove it. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- arch/powerpc/kernel/pci_32.c | 11 ----------- 1 file changed, 11 deletions(-) Index: linux-work/arch/powerpc/kernel/pci_32.c ===================================================================--- linux-work.orig/arch/powerpc/kernel/pci_32.c 2007-12-05 11:36:30.000000000 +1100 +++ linux-work/arch/powerpc/kernel/pci_32.c 2007-12-05 11:36:36.000000000 +1100@@ -922,17 +922,6 @@ long sys_pciconfig_iobase(long which, un struct pci_controller* hose; long result = -EOPNOTSUPP; - /* Argh ! Please forgive me for that hack, but that's the - * simplest way to get existing XFree to not lockup on some - * G5 machines... So when something asks for bus 0 io base - * (bus 0 is HT root), we return the AGP one instead. - */ -#ifdef CONFIG_PPC_PMAC - if (machine_is(powermac) && machine_is_compatible("MacRISC4")) - if (bus == 0) - bus = 0xf0; -#endif /* CONFIG_PPC_PMAC */ -
I believe, with this patch, you are officially forgiven. :-) jdl