Re: [PATCH v2] qe: add ability to upload QE firmware

On Thursday 06 December 2007, Timur Tabi wrote:

quoted

I'm not trying to convince you of this if it's completely pointless for
all your systems, just want to make sure you're aware of this option,
because spending a few extra code lines on it now may save you some tro=

uble

quoted

if you need this later.

=20
Um, I think I'm a little confused as to what your point is. =A0My code is=

 just a=20

generic QE firmware uploader.

My point is that you could have some extra code that calls your
qe_upload_firmware() when the device tree contains the blob but the boot
loader did not already load it. This helps e.g. for the case where you
want to be able to install a generic Linux distribution that is not
able to ship with your firmware blob in the kernel or the root file system.
Putting the blob in the device tree makes it easier to get to a running
system then.

You can argue that the boot loader can always load the firmware in the
first place, but then you wouldn't need an implementation of
qe_upload_firmware in the kernel any more.

	Arnd <><