Thread (4 messages) read the whole thread 4 messages, 2 authors, 2007-12-20

Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

From: Andy Whitcroft <hidden>
Date: 2007-12-20 14:45:48
Also in: lkml

On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote:
+		/* Make the sysace device 'live' */
+		if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
+			add_disk(ace->gd);
checkpatch.pl reports the above if as suspect due to the trailing ;.
Looks wrong to me too.

WARNING: Trailing semicolon indicates no statements, indent implies
otherwise
#296: FILE: drivers/block/xsysace.c:835:
+               if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
+                       add_disk(ace->gd);

-apw
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help