Thread (4 messages) 4 messages, 2 authors, 2007-11-30

Re: [RFC/PATCH] Add a device_initcall to machdep_calls

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-11-30 23:03:37

On Fri, 2007-11-30 at 15:51 -0700, Grant Likely wrote:
Add a device_initcall hook to machdep_calls so that platform code
doesn't
need to register device_initcalls that must first check what platform
it is running on.

This should (slightly) speed boot time on kernels that support a lot
of
boards and make device_initcall hooks slightly simpler to implement
because the platform doesn't need to be tested when called.

Signed-off-by: Grant Likely <redacted>
---

Please comment; I think this is a good change, but I'd like some
feedback.
Hrm... I'm not too sure about it... 

My initial idea for dealing with that issue was more along the lines of
defining a set of

machine_xxx_initcall(mach, function)

Where xxx is (arch,core,subsys,fs,device, whatever...)

Those could, at first be implemented as a simple macro wrapper that
expands to a function that tests machine_is() and calls the function,
and later one, we can do more fancy things, such as ELF sections with
function pointers in them.

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help