Re: [PATCH 15/24] powerpc: early debug forces console log level to max
From: T Ziomek <hidden>
Date: 2007-11-30 19:10:05
From: T Ziomek <hidden>
Date: 2007-11-30 19:10:05
On Fri, 30 Nov 2007, Benjamin Herrenschmidt wrote:
This patch makes the early debug option force the console loglevel to the max. The early debug option is meant to catch messages very early in the kernel boot process, in many cases, before the kernel has a chance to parse the "debug" command line argument. Thus it makes sense when CONFIG_PPC_EARLY_DEBUG is set, to force the console log level to the max at boot time.
. . .
+#ifdef CONFIG_PPC_EARLY_DEBUG + console_loglevel = 10; +#endif }
The change makes sense, but wouldn't it also make sense to note it in
arch/powerpc/Kconfig.debug? Otherwise it's really hard to figure out why,
after bringing up a new board, removing "debug" from the kernel cmd line
does, well, nothing.
Tom
--
/"\ ASCII Ribbon Campaign |
\ / | Email to user 'CTZ001'
X Against HTML | at 'email.mot.com'
/ \ in e-mail & news |