On Fri, 2007-11-30 at 12:14 +0800, Olof Johansson wrote:

Hi,

On Fri, Nov 30, 2007 at 11:45:34AM +0800, Li Li wrote:

quoted

+     pci2@e0009000 {

Why call it pci2@ (and pci3@ below)? They are clearly identifiable
with 
their unit addresses anyway.

quoted

+config PPC_MPC83XX_PCIE 
+     bool "MPC837X PCI Express support" 
+     depends on PCIEPORTBUS && PPC_MPC837x 
+     default n 
+     help 
+       Enables MPC837x PCI express RC mode

Why have a separate config option for this?

For systems where you don't want PCI-e configured, it should be left 
out of the device tree instead.

It is easy to configure kernel than modify and recompile the dts.
The pcie is default enabled in dts.

-Olof

- Tony