On Tue, Nov 06, 2007 at 02:42:08AM +0100, Segher Boessenkool wrote:
Hi Olof,
Nice cleanup! One minor thing...
quoted
static struct of_device_id pasemi_bus_ids[] = {
+ /* Unfortunately needed for legacy firmwares */
{ .type = "localbus", },
{ .type = "sdc", },
+ { .compatible = "pasemi,localbus", },
+ { .compatible = "pasemi,sdc", },
The new comment is for the device_type entries only, right? You
might want to make that more clear.
Good point. I'll clarify it with a new comment above the compatible
entries. I won't repost the patch since the change is minor, but include
it for the upstream push.
Thanks,
-Olof