Thread (2 messages) flat view 2 messages, 2 authors, 2007-11-13

Re: [PATCH] powerpc: Add support for PORTA and PORTB odr registers

From: Scott Wood <hidden>
Date: 2007-11-13 23:47:10
Also in: lkml 

Jochen Friedrich wrote:
quoted hunk ↗ jump to hunk
@@ -474,6 +481,12 @@ static void cpm1_set_pin16(int port, int pin, int 
flags)
    else
        clrbits16(&iop->par, pin);

+    if (port == CPM_PORTA) {
+        if (flags & CPM_PIN_OPENDRAIN)
+            setbits16(&iop->odr, pin);
+        else
+            clrbits16(&iop->odr, pin);
+    }
    if (port == CPM_PORTC) {
        if (flags & CPM_PIN_SECONDARY)
            setbits16(&iop->sor, pin);
Where is the odr field of cpm_ioport16 defined?  It's the same position 
as sor, so maybe call it odr_sor or something.

Also, please add an extra newline after the closing brace.

-Scott
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help