On Tue, 30 Oct 2007 20:56:51 -0500
Olof Johansson [off-list ref] wrote:

On Wed, Oct 31, 2007 at 10:08:05AM +1100, David Gibson wrote:

quoted

On Tue, Oct 30, 2007 at 07:56:50PM +0300, Valentine Barshak wrote:

quoted

PowerPC 440GRx Rainier DTS.

[snip]

quoted

+		SDRAM0: sdram {
+			device_type = "memory-controller";

How many times do we need to say it...

Don't make up random device_type values.  This does not belong here.

Maybe there should be something like checkpatch.pl that warns about
these kinds of things so people can check for it without getting flamed
first. :-)

That's actually a decent idea.  We could even have this thing that
takes DTS files and processes them...  oh wait.

So why can't we make a whitelist of "allowed" device_types in DTC and
make it whine about anything outside of that?

josh