Thread (18 messages) flat view 18 messages, 4 authors, 2007-10-29

Re: [PATCH] fix appletouch geyser 1 breakage

From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Date: 2007-10-24 12:56:00

Hi Johannes,

On 10/24/07, Johannes Berg [off-list ref] wrote:
The patch 46249ea60fbb61a72ee6929b831b1f3e6865f024 was obviously done
without testing on a Geyser 1,
My fault, sorry. However Anton's device has product ID of 90x30B which
is Geyser 1 as far as I understand... But yes, we should not expect
other geysers respond to Geyser 3-specific commands.
 and I'm a very annoyed that it was
applied. It causes appletouch to continuously printk:

drivers/input/mouse/appletouch.c: Could not do mode read request from device (Geyser 3 mode)

because the Geyser 1 doesn't respond to that. The patch description also
states:
quoted
if we see 10 empty packets the touchpad needs to be reset; good
touchpads should not send empty packets anyway.
which is *TOTALLY* bogus since Geyser 1 touchpads have no notion of
empty packets, the simply continuously send measurements. One look at
the specification would have confirmed that.
Is there a way to "plug" these Geysers? Waking up the kernel
continuously is not nice.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help