Re: [PATCH] powerpc: mpic: minor optimization of ipi handler
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-10-19 23:17:50
On Fri, 2007-10-19 at 13:51 -0500, Olof Johansson wrote:
Jeff Garzik pointed out that we don't actually have to lookup the mpic instance since it's passed in as the interrupt handler data for IPIs.
Note that's typically one of the annoying case where we use "irq" for a good reasons, getting the way of Jeff attempt at removing this argument. I suppose a working approach would be to have 4 mpic IPI handlers... Ben.
quoted hunk ↗ jump to hunk
Signed-off-by: Olof Johansson <redacted>diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c index e479388..6bf56f4 100644 --- a/arch/powerpc/sysdev/mpic.c +++ b/arch/powerpc/sysdev/mpic.c@@ -612,11 +612,10 @@ static inline void mpic_eoi(struct mpic *mpic) } #ifdef CONFIG_SMP -static irqreturn_t mpic_ipi_action(int irq, void *dev_id) +static irqreturn_t mpic_ipi_action(int irq, void *data) { - struct mpic *mpic; + struct mpic *mpic = data; - mpic = mpic_find(irq, NULL); smp_message_recv(mpic_irq_to_hw(irq) - mpic->ipi_vecs[0]); return IRQ_HANDLED;_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev