Thread (9 messages) flat view 9 messages, 4 authors, 2007-10-08

Re: [PATCH] fsl_spi_init: Support non-QE processors

From: Peter Korsgaard <jacmet@sunsite.dk>
Date: 2007-10-03 16:05:00

quoted
quoted
quoted
quoted
"Grant" == Grant Likely [off-list ref] writes:
Hi,

 Grant> Why not just:

 Grant>         np = of_find_node_by_type(NULL, "qe");
 Grant> +       if (!np)
 Grant> +               np = of_find_node_by_type(NULL, "soc");
 Grant>         if (!np)
 Grant>                 return -ENODEV;

My first iteration did it like that, but then you don't get a -ENODEV
if the node is missing (and you'll end up using the wrong clock) and
it doesn't support processors with SPI on and off QE (if that
exists/will ever exist).

-- 
Bye, Peter Korsgaard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help