Re: CONFIG_BLK_DEV_BSG=n

On Mon, Sep 17 2007, David Howells wrote:

James Bottomley [off-list ref] wrote:

quoted

quoted

Which solution would you be more comfortable with?

The one which is currently in -mm is this one:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=49892223f7d3a2333ef9e6cbdd526676e1fc517a

In my opinion, this is the wrong fix.  There shouldn't be anything in
the kernel using stuff from bsg.h if CONFIG_BLOCK=n, so there should
be an error if anything tries to.  The correct fix is to exclude the
non-userspace-visible contents of bsg.h with #ifdef CONFIG_BLOCK, not
to declare things that we've tried to make sure specifically aren't
declared.

I agree, I'll pass your fix on.

-- 
Jens Axboe