Re: [PATCH v2] pcmcia: Convert io_req_t to use kio_addr_t
From: Christoph Hellwig <hch@lst.de>
Date: 2007-09-22 09:13:36
Also in:
lkml
From: Christoph Hellwig <hch@lst.de>
Date: 2007-09-22 09:13:36
Also in:
lkml
On Sat, Sep 22, 2007 at 12:25:51AM -0600, Matthew Wilcox wrote:
quoted
What about the formatting and field widths ? ulong would probably be a lot saner than kio_addr_t and yet more type obfuscation.I don't think anyone uses ioports > 32bit. Certainly i386 takes an int port as parameter to {in,out}[bwl] (and it really only uses 16-bits). parisc uses 24 bits. I don't know what the various ppcs do, but pci bars can only be 32-bit for ioports. So my opinion is that ioports should be uint, not ulong.
The kernel seems to mostly use int, sometimes uint. I never quite got why pcmcia had to have it's own strange typedef for them.