Thread (4 messages) flat view 4 messages, 4 authors, 2007-09-15

Re: rtc-ds1742.c should use resource_size_t for base address

From: Atsushi Nemoto <hidden>
Date: 2007-09-14 16:45:04
Also in: lkml

On Fri, 14 Sep 2007 15:54:27 +1000, David Gibson [off-list ref] wrote:
Currently the rtc driver, rtc-ds1742.c uses an unsigned long to store
the base mmio address of the NVRAM/RTC.  This breaks on systems like
PowerPC 440, which is a 32-bit core with 36-bit physical addresses: IO
on the system, including the RTC, is typically above the 4GB point,
and cannot fit into an unsigned long.

This patch fixes the problem by replacing the unsigned long with a
resource_size_t.  Tested on Ebony (PPC440) (with additional patches to
instantiate the ds1742 platform device appropriately).

Signed-off-by: David Gibson <redacted>
Thanks!

Acked-by: Atsushi Nemoto <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help