Thread (16 messages) flat view 16 messages, 2 authors, 2007-09-12

Re: [PATCH 08/12] IB/ehca: Replace get_paca()->paca_index by the more portable smp_processor_id()

From: Joachim Fenkes <hidden>
Date: 2007-09-12 14:43:06
Also in: lkml

On Tuesday 11 September 2007 16:51, Nathan Lynch wrote:
quoted
-				   get_paca()->paca_index, __FUNCTION__, \
+				   smp_processor_id(), __FUNCTION__, \
I think I see these macros used in preemptible code (e.g. ehca_probe),
where smp_processor_id() will print a warning when
CONFIG_DEBUG_PREEMPT=y.  Probably better to use raw_smp_processor_id.
You're right, man. The processor id doesn't need to be preemption-safe in this
context, so that would be a bogus warning. Thanks for pointing this out. I'll
post a new version of this patch.

Joachim
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help