[PATCH 08/15] Use spufs_coredump_num_notes everywhere, and don't NULL terminate
From: Michael Ellerman <hidden>
Date: 2007-09-12 07:46:37
Also in:
lkml
Subsystem:
cell broadband engine architecture, linux for powerpc (32-bit and 64-bit), spu file system, the rest · Maintainers:
Madhavan Srinivasan, Linus Torvalds
The spufs_coredump_read array is NULL terminated, and we also store the size. We only need one or the other, and storing the size should save a teensy bit of memory vs NULL terminating, so do that. Signed-off-by: Michael Ellerman <redacted> --- arch/powerpc/platforms/cell/spufs/coredump.c | 2 +- arch/powerpc/platforms/cell/spufs/file.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/cell/spufs/coredump.c b/arch/powerpc/platforms/cell/spufs/coredump.c
index 52d6219..8348d21 100644
--- a/arch/powerpc/platforms/cell/spufs/coredump.c
+++ b/arch/powerpc/platforms/cell/spufs/coredump.c@@ -72,7 +72,7 @@ static int spufs_ctx_note_size(struct spu_context *ctx, int dfd) char *name; char fullname[80]; - for (i = 0; spufs_coredump_read[i].name; i++) { + for (i = 0; i < spufs_coredump_num_notes; i++) { name = spufs_coredump_read[i].name; sz = spufs_coredump_read[i].size;
diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c
index 85edbec..220c7fe 100644
--- a/arch/powerpc/platforms/cell/spufs/file.c
+++ b/arch/powerpc/platforms/cell/spufs/file.c@@ -2250,7 +2250,6 @@ struct spufs_coredump_reader spufs_coredump_read[] = { { "proxydma_info", __spufs_proxydma_info_read, NULL, sizeof(struct spu_proxydma_info)}, { "object-id", NULL, __spufs_object_id_get, 19 }, - { }, }; -int spufs_coredump_num_notes = ARRAY_SIZE(spufs_coredump_read) - 1; +int spufs_coredump_num_notes = ARRAY_SIZE(spufs_coredump_read);
--
1.5.1.3.g7a33b