Thread (3 messages) 3 messages, 3 authors, 2007-08-29

Re: [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id

From: Ishizaki Kou <hidden>
Date: 2007-08-29 09:26:54
Also in: lkml

Christian Krafft wrote:
On Thu, 23 Aug 2007 18:12:19 +0200
Arnd Bergmann [off-list ref] wrote:
quoted
On Thursday 23 August 2007, kou.ishizaki@toshiba.co.jp wrote:
quoted
Please check "unit-id" if "physical-id" doesn't exist. Because
Celleb
quoted
quoted
uses "unit-id" to provide spe_id.
Sorry for the late answer, wasn't on cc
and had to receive all mails of the last 6 month once again :-(

Can you check if the patch below is working with celleb device tree ?

------
Subject: spu_manage: fix spu_unit_number for celleb device tree

From: Christian Krafft <redacted>

New device trees provide "physical-id".
Celleb device tree provide the "unit-id".
Legacy device tree used the reg property for the physical id of an
spe.
This patch fixes find_spu_unit_number to look for the spu id in that
order.
The length is checked to avoid misinterpretation in case the
attributes
unit-id or reg do not contain the id.

Signed-off-by: Christian Krafft <redacted>
Acked-by: Kou Ishizaki <redacted>

It works good on Celleb, thanks.  Please apply it to 2.6.23.

Best regards,
Kou Ishizaki
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help