Re: [PATCH] lro: eHEA example how to use LRO

Hi Auke,

On Friday 03 August 2007 22:29, Kok, Auke wrote:

Jan-Bernd Themann wrote:

quoted

This patch shows how the generic LRO interface is used for SKB mode

Signed-off-by: Jan-Bernd Themann <redacted>

---
 drivers/net/Kconfig             |    1 +
 drivers/net/ehea/ehea.h         |    9 ++++-
 drivers/net/ehea/ehea_ethtool.c |   15 +++++++
 drivers/net/ehea/ehea_main.c    |   84 +++++++++++++++++++++++++++++++++++---
 4 files changed, 101 insertions(+), 8 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f8a602c..fec4004 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig

<snip>

quoted

+module_param(use_lro, int, 0);

Have you looked at my generic lro get/set patch that I posted this week? this 
adds a useless module parameter while ethtool has all the structure already to 
accomodate setting lro on/off.

Yes, I saw your patch. Looks very good to me. I will modify our driver soon
to use ethtool instead of this module parameter.

Thanks for adding this support to the ethtool interface.