Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

On Thursday 02 August 2007, Hoang-Nam Nguyen wrote:

+#ifdef CONFIG_PPC_64K_PAGES
+=A0=A0=A0=A0=A0=A0=A0/* make sure we map only 4k for fw context */
+=A0=A0=A0=A0=A0=A0=A0ret =3D remap_4k_pfn(vma, vma->vm_start, physical >=
EHCA_PAGESHIFT,
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =

=A0 vma->vm_page_prot);

+#else
=A0=A0=A0=A0=A0=A0=A0=A0ret =3D remap_pfn_range(vma, vma->vm_start, physi=

cal >> PAGE_SHIFT,

=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =

=A0 =A0 =A0vsize, vma->vm_page_prot);

+#endif

remap_4k_pfn is defined in terms of remap_pfn_range if the base page
size if 4k, so you don't need this #ifdef afaics.

otherwise, the patch looks good.

	Arnd <><