Re: [PATCH 1/2] Xlinx ML403 AC97 Controller Reference device driver

At Thu, 09 Aug 2007 22:01:40 +0200,
Joachim Förster wrote:

Hi Grant,

On Thu, 2007-08-09 at 11:49 -0600, Grant Likely wrote:

quoted

quoted

diff --git a/sound/ppc/Makefile b/sound/ppc/Makefile
index eacee2d..827f2f5 100644
--- a/sound/ppc/Makefile
+++ b/sound/ppc/Makefile

Couldn't this end up on MicroBlaze too?  If so, sound/ppc is the wrong place.

Well, I don't know. The only arch depended calls I use (am aware of) are
in/out_be32(), so this _might_ work for mb, too. (I won't be able to
test that in the next few months ...)

On Thu, 2007-08-09 at 11:17 -0700, Stephen Neuendorffer wrote: 

quoted

 I second grant here... this should eventually work on microblaze, too,
so putting it drivers/ and using XILINX_DRIVERS instead of XILINX_VIRTEX
(based on the patch Wolfgang recently posted) would probably be preferable.

quoted

+
+config SND_ML403_AC97CR
+       tristate "Xilinx ML403 AC97 Controller Reference"
+       depends on SND && XILINX_VIRTEX

Steve

So, like Stephen Neuendorffer said, I should move it to sound/drivers,
right? Takashi?

Well, yes, drivers appears like a more reasonable place.

On Thu, 2007-08-09 at 11:49 -0600, Grant Likely wrote:

quoted

quoted

+snd-ml403_ac97cr-objs := ml403_ac97cr.o

This line is only needed if you're compiling multiple .c files into one .ko

Ah, well, then I have to rename the main .c file. But all the other ALSA
drivers seem to _not_ include the "snd-" in front of it (ok, except the
new PS3 driver and maybe other new ones?)

Right.  I prefer the file name should be without prefix, too.
The snd- prefix came from a historical reason, to avoid the name crash
with OSS drivers.


Takashi