On Fri, Aug 17, 2007 at 03:45:02PM -0500, Scott Wood wrote:
On Fri, Aug 17, 2007 at 07:05:52PM +0200, Arnd Bergmann wrote:
quoted
The m8260_pci.h file is not namespace clean, it defines macros like
PCI_CFG_ADDR_REG that are likely to create conflicts at some point of
time. Since the only file including this header is
arch/powerpc/platforms/82xx/m82xx_pci.h, I'd suggest merging the two,
to make sure nobody can accidentally include it.
Better yet, just get rid of that define -- nothing uses it AFAICT.
To elaborate, I grepped for all of the symbols defined in m8260_pci.h,
and none get any hits in arch/powerpc.
-Scott