Thread (15 messages) flat view 15 messages, 5 authors, 2007-08-11

Re: [PATCH] remove gratuitous reads from pasemi pci config space methods

From: Olof Johansson <hidden>
Date: 2007-08-11 23:41:22

On Thu, Aug 09, 2007 at 04:37:27PM -0500, Nathan Lynch wrote:
The pasemi pci configuration space write method reads the written
location immediately after the write is performed, presumably in order
to flush the write.  However, configuration space writes are not
allowed to be posted, making these reads gratuitous.  Furthermore,
this behavior potentially causes us to violate the PCI PM spec when
changing between e.g. D0 and D3 states, because a delay of up to 10ms
may be required before the OS accesses configuration space after the
write which initiates the transition.

Remove the unnecessary reads from pa_pxp_write_config.
Thanks!
Signed-off-by: Nathan Lynch <redacted>
Acked-by: Olof Johansson <redacted>


-Olof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help