Thread (10 messages) 10 messages, 5 authors, 2007-08-01

Re: [PATCH] powerpc: Pegasos keyboard detection

From: Segher Boessenkool <hidden>
Date: 2007-07-31 21:29:48
Also in: lkml

Possibly related (same subject, not in this thread)

quoted hunk ↗ jump to hunk
As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse 
controller
on the PegasosPPC. This is because of a feature/bug in the OF device 
tree:
the "device_type" attribute is an empty string instead of "8042" as the
kernel expects. This patch (against 2.6.22.1) adds a secondary 
detection
which looks for a device whose *name* is "8042" if there is no device 
whose
*type* is "8042".

Signed-off-by: Alan Curry <redacted>
--- arch/powerpc/kernel/setup-common.c.orig	2007-07-24 
19:04:17.000000000 -0500
+++ arch/powerpc/kernel/setup-common.c	2007-07-24 19:06:36.000000000 
-0500
@@ -487,6 +487,10 @@ int check_legacy_ioport(unsigned long ba
 	switch(base_port) {
 	case I8042_DATA_REG:
 		np = of_find_node_by_type(NULL, "8042");
+		/* Pegasos has no device_type on its 8042 node, look for the
+		 * name instead */
+		if (!np)
+			np = of_find_node_by_name(NULL, "8042");
[I know it already got merged, I'm behind on mail, but anyway...]

Could board-specific quirks like this please always include a
check for that board?  Or, even better, do a fixup in the
bootwrapper.

In this case the workaround won't likely trigger on the wrong
boards, but "just a little bit" more dangerous workarounds
_will_, and the law of big numbers works against us...


Segher
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help