Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile
From: Kok, Auke <hidden>
Date: 2007-07-30 17:01:42
Also in:
lkml, netdev
From: Kok, Auke <hidden>
Date: 2007-07-30 17:01:42
Also in:
lkml, netdev
Jeff Garzik wrote:
Stephen Hemminger wrote:quoted
Why make this a user selectable option at all? Unless you want to deal with out of tree drivers (not my problem), it should be hidden to avoid having to explain an support it.In this case it's an optional library kernel module. That seems to be a common setup for library modules. We do the same with CONFIG_MII and drivers/net/mii.ko as well. Originally it was done purely in the Makefile, but that does not account for net drivers in sub-directories (or out of tree as you point out).
speaking of that, shouldn't there be a NETIF_F_LRO ? Auke