Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

On 07/19/2007 11:47 AM, Andrew Morton wrote:

On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven [off-list ref] wrote:

quoted

quoted

Oh dear.

	ps3rom_priv(dev) = host;

that's 'orrid.  We have an identifier pretending to be a function, only we
go and treat it as an lvalue.

I mean, C code should look like C code, and the above just doesn't.

Sigh.

You could insist that it be PS3ROM_PRIV() because then it at least also 
_looks_ like cpp...

Rene.