Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target

On Sat, 07 Jul 2007 20:46:46 +0400
Sergei Shtylyov wrote:

quoted

+
+#ifdef CONFIG_MPC834x_ITX  

    Erm, isn't this stuff misplaced? Is this really SoC device? I
remember seeng this in the arch/ppc/ platform code before (in the
internal tree)...

The point is to declare methods bsp, as mmio access may effectively vary (having bugs or intentionally) from platform to platform. All-in-one driver approach is nice but might be an issue to handle/maintain.

Thanks for looking at it, other notes make sense.

-- 
Sincerely, Vitaly