RE: [PATCH 5/6 v2] 85xxCDS: Misc 8548 PCI Corrections.

=20

-----Original Message-----
From: Randy Vinson [mailto:rvinson@mvista.com]=20
Zang Roy-r61911 wrote:

quoted

On Sat, 2007-07-21 at 06:31, Randy Vinson wrote:
=20

quoted

@@ -272,10 +272,10 @@ static void __init=20

mpc85xx_cds_setup_arch(void)

quoted

quoted

        for (np =3D NULL; (np =3D of_find_node_by_type(np, "pci")) =

!=3D

quoted

quoted

NULL;) {
                struct resource rsrc;
                of_address_to_resource(np, 0, &rsrc);
-               if ((rsrc.start & 0xfffff) =3D=3D 0x9000)
-                       fsl_add_bridge(np, 0);
-               else
+               if ((rsrc.start & 0xfffff) =3D=3D 0x8000)
                        fsl_add_bridge(np, 1);
+               else
+                       fsl_add_bridge(np, 0);

Why this is needed?
For pcie@a000, fsl_add_bridge(np, 0)?

The old version of the code would call fsl_add_bridge(np, 1) for the
host bridges @8000 and @a000. When I tried it that way, it=20
didn't work

What did not work? I tried two Ethernet cards @8000 and @a000. they
worked..

I don't think you can have 2 primary bridges.

Why?
They belong to two separate pci domain.
Roy