Thread (11 messages) flat view 11 messages, 5 authors, 2007-07-20

Re: [PATCH] Treat ISI faults as read faults on classic 32-bit PowerPC

From: Segher Boessenkool <hidden>
Date: 2007-07-19 17:17:03

quoted
Hmmm.  The dangling else clauses are pretty gross, and in fact we  
have
the same problem on POWER3 and RS64 processors (to be fair, we had
the problem before and didn't notice, but we should still fix it).

How about this instead?  Could people test it please?  (Note that
CPU_FTR_NOEXECUTE is 0 in 32-bit kernels.)

Paul.
diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c
index 0ece513..99c3093 100644
--- a/arch/powerpc/mm/fault.c
+++ b/arch/powerpc/mm/fault.c
Acked-by: Jon Loeliger <redacted>

Tested on 8641HPCN.
Which glibc versions?  glibc-2.4 and newer are fine without the
patch already, glibc-2.3 seems to get away by accident; but 2.2
(and before) are the problematic ones.

No other userland program has been identified as needing this
fix, btw -- thankfully, or the testing matrix would be _huge_.


Segher
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help