Thread (3 messages) flat view 3 messages, 2 authors, 2007-07-19

Re: [PATCH 10/61] bootwrapper: flatdevtree fixes

From: Scott Wood <hidden>
Date: 2007-07-18 18:56:01

Milton Miller wrote:
In-Reply-To: [ref]

On Wed Jul 18 11:33:08 EST 2007, Scott Wood wrote:
quoted
1. ft_create_node was returning the internal pointer rather than a 
phandle.
2. ft_find_device_rel was treating lookups relative to root as an error.

No, it is treating lookups relative to NULL as an error.

Your patch changes it to treat lookups relative to the NULL phandle as 
relative to root.
Other parts of the code (such as ft_create_node) already do that. 
What's wrong with it?
I've no objections to the other part, can you split these?
No, because change #1 won't work without change #2.

-Scott
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help