Thread (6 messages) flat view 6 messages, 4 authors, 2007-07-17

Re: [PATCH] POWERPC: Added RTC support for mpc8313RDB and utilize "clock-frequency"

From: Scott Wood <hidden>
Date: 2007-07-17 17:53:18

Vitaly Bordug wrote:
On Tue, 17 Jul 2007 11:36:45 -0500
Scott Wood [off-list ref] wrote:
quoted
We should be removing this from board files that have it, not adding it
to ones that don't.
Yet many boards still have this stuff (like pretty recent 86xx) - should
we at least add some comments or clean that up?
See above. :-)

AFAICT, it's just copied from board to board without thought.  It should 
be removed.
quoted
The ppc_md RTC functions should really just go away, though -- setting
the clock on bootup can be done by generic code, and periodically
updating the RTC when using NTP can be done from userspace.
If those ppc_md hookups would be declared deprecated, there's no much sense in the upper,
apparently. But I am not sure they will be... I'm inclined to let this patch floating since
interacting with rtc class from within BSP code just does not worth it.
I'm not sure they will either; I just wish they would be. :-)

In the meantime, some sort of workqueue-based hookup to the RTC class 
API should be used.  I believe there have been patches along those lines 
posted in the past.

-Scott
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help