RE: [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file.
From: Zhang Wei-r63237 <hidden>
Date: 2007-06-18 03:28:18
Also in:
lkml
Hi, Kumar and Segher,=20
quoted
"..8641.." "..8641d.." "..8548.." "..8548e.." "..8543.."=20"..8543e.."=20quoted
"..8572.." "..8572e.." "..8567.." "..8567e.." "..8568.." "..8568e.."=20 You don't need to mention _all_ compatible devices in the "compatible" property, only the few that matter; typically the oldest one, and sometimes some intermediate device that has extra features over the original one. =20
The oldest one is difficult to find out sometime. Can we only set the
self name in dts, such as "fsl, rapidio-8641", and add this 'compatible'
property to the driver ids arrays? Such as:
static struct of_device_id of_rio_rpn_ids[] =3D {
{ .compatible =3D "fsl, rapidio-8540",},
{ .compatible =3D "fsl, rapidio-8560",},
{ .compatible =3D "fsl, rapidio-8641",},
{ .compatible =3D "fsl, rapidio-8548",},
{},
};
How about that?
It isn't useful to add "compatible" entries that no OS probes for. =20quoted
quoted
Concrete names are good.While I agree concrete names are good, we put these 'blocks' in so=20 many devices that using the device to match on is pointless.=20 You *definitely* should put the device name for _this_ device in there, in case it needs some special workaround. =20quoted
I'm all for making up a name like 'Grande', 'Del',=20'Janeiro'. This is=20quoted
effective what we did with gianfar. The name gets picked up pretty=20 quickly by people.=20 That can be used as the "base" name, yes. =20
Do you have the name list? I can change my codes according them. How about 'Mercurary', 'Venus', 'Earth', 'Mars', 'Saturn', 'Jupiter', 'Uranus', 'Neptune', Or 'Aries', 'Taurus', 'Gemini', 'Cancer', 'Leo', 'Virgo', 'Libra', 'Scorpius', 'Sagittarius', 'Capricornus', 'Aquarius', 'Pisces' ? Thanks! Wei.