Re: [patch] powerpc: sysfs fix compiler warning
From: Josh Boyer <hidden>
Date: 2007-06-22 18:38:43
On Fri, 2007-06-22 at 19:48 +0200, Christian Krafft wrote:
quoted hunk ↗ jump to hunk
From: Christian Krafft <redacted> This patch fixes the following compiler warning: arch/powerpc/kernel/sysfs.c:385: warning: ignoring return value of `sysfs_create_group', Signed-off-by: Christian Krafft <redacted> Index: linux-2.6.22-rc5/arch/powerpc/kernel/sysfs.c ===================================================================--- linux-2.6.22-rc5.orig/arch/powerpc/kernel/sysfs.c +++ linux-2.6.22-rc5/arch/powerpc/kernel/sysfs.c@@ -380,16 +380,23 @@ int cpu_add_sysdev_attr_group(struct att { int cpu; struct sys_device *sysdev; + int error; mutex_lock(&cpu_mutex); for_each_possible_cpu(cpu) { sysdev = get_cpu_sysdev(cpu); - sysfs_create_group(&sysdev->kobj, attrs); + error |= sysfs_create_group(&sysdev->kobj, attrs);
Why are you or'ing the return value with whatever is in the uninitialized variable? josh