Re: [PATCH] rheap: eliminates internal fragments caused by alignment

On Mon, 2007-06-18 at 15:31 +0300, Pantelis Antoniou wrote:

On 18 =CE=99=CE=BF=CF=85=CE=BD 2007, at 3:25 =CE=9C=CE=9C, Joakim Tjernlu=

nd wrote:

=20

quoted

On Mon, 2007-06-18 at 15:14 +0300, Pantelis Antoniou wrote:

quoted

Hi Li,

The patch appears fine at first glance.

I'm really curious what kind of alignment do you use in order to =20
have so
much wasted space that re-inserting the leftovers makes so much of a
difference.

=20
Jocke,
=20
Ugh, 256?

Yes, the ucc_geth needs lots of alignment. Leo can tell you more :)

=20
That's not nice at all.
I'm not sure that even then you're going to have any guarantees that
the allocations will be successful.
=20
I'm afraid that in those case it would be better for the board
platform setup to have the space preallocated according to the BSP
requirements.

Maybe, but without the PATCH you will run out of space very quickly
and you cannot bring up 3 ethernet interfaces. Rheap is plain wrong
as is today and needs this patch.

 Jocke

=20
Just my $0.02.
=20
-- Pantelis