Thread (7 messages) 7 messages, 4 authors, 2007-06-06

RE: [PATCH] of_serial: ignore unknown serial port

From: kouish <hidden>
Date: 2007-06-06 09:28:25

Ishizaki Kou writes:
quoted
Current of_serial driver assumes unknown serial port to be 8250. But
this behavior may cause fatal problems when the serial port is not
8250. This patch corrects probe routine to ignore unknown 
serial port.
quoted
Signed-off-by: Kou Ishizaki <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
Is this a bugfix that needs to go in 2.6.22?  Likewise, is your next
patch (of_serial: add port type checking) needed in 2.6.22?

Paul.
Paul-san,

Thank you to ask me about our patches to of_serial driver.

We need the 'ignore unknown serial port' patch in 2.6.22 because
assuming an unknown port as 8250 may cause fatal problems on Celleb
with our new device tree which has 'serial' type device nodes. These
serial ports are not 8250.

On the other hand, we have no problem even if the 'of_serial: add port
type checking' patch will be merged in 2.6.23.

Best regards,
Kou Ishizaki
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help