Re: [PATCH v2]: Fix e500 v2 core reboot bug
From: Zang Roy-r61911 <hidden>
Date: 2007-06-04 08:29:22
On Wed, 2007-05-30 at 21:49, Kumar Gala wrote:
quoted
quoted
quoted
quoted
quoted
I'm not terrible happy with blindly writing to rstcr.I can understand you. But I jut want to make things simple and workable. Any idea?one idea would be for us to add a property on the soc node. Something like has-rstcr or something similar in a guts node?I have seen your suggestion before to add a property in devicetree.quoted
quoted
But I still think the current implementation is simple.While it simple you are depending on the fact that a given implementation may or may not have something at the particular offset. Who knows if 8599 or some future part could put the 'cause my part to smoke and self-destruct' at the same offset in the future :)quoted
Anyway, I can try your suggestion.I'm thinking have a guts block and putting a property in it makesthequoted
most sense.After some discussion on IRC I think the following is the suggested node we should add in. guts@e00000 { compatible = "fsl,mpc8548-guts"; reg = <e00000 1000>;
one more zero!
fsl,has-rstcr; };