Re: [PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t

On Mon, May 14, 2007 at 05:57:31PM -0500, Olof Johansson wrote:

On Sun, May 13, 2007 at 11:46:08PM +0200, Christoph Hellwig wrote:

quoted

On Sat, May 12, 2007 at 09:31:05AM -0500, Olof Johansson wrote:

quoted

ppc64 really needs ioaddr_t to be 64-bit, since I/O addresses really
are MMIO addresses, and remapped to a high range.

While the type is exported to userspace, there hasn't been any platforms
with PCMCIA on 64-bit powerpc until now, so changing it won't regress
any existing users.

In fact the only use of the type should be in the obsolete ioctl-based user
interface.  So instead of changing the size of the type you should

 a) make sure you're not using cardmgr
 b) fix up those places that still use ioaddr_t where they shouldn't
    and switch the to kio_addr_t (why not just unsigned long like all
    other busses?) 

I just noticed that feature-removal-schedule.txt says November 2005 for
the removal of the pcmcia ioctl's, but they're still there. I'm missing
the history here, any reason they weren't removed yet?

See the discussions on lkml.  It seems like people haven't really
noticed the deprecation messages and are still using it.  Still not
a good reason to use them on a new port (at least new in terms of
pcmcia support)