Re: [PATCH 1/2] Declare {compat_}sys_utimensat
From: Arnd Bergmann <arnd@arndb.de>
Date: 2007-05-09 16:22:23
Also in:
lkml
On Wednesday 09 May 2007, Stephen Rothwell wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/linux/compat.h b/include/linux/compat.h index ccd863d..70a157a 100644 --- a/include/linux/compat.h +++ b/include/linux/compat.h@@ -253,5 +253,8 @@ asmlinkage long compat_sys_epoll_pwait(int epfd,=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0c=
onst compat_sigset_t __user *sigmask,
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0c=
ompat_size_t sigsetsize);
=A0 +asmlinkage long compat_sys_utimensat(unsigned int dfd, char __user *file=
name,
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0struct compat_timespec __user *t, int flags);
quoted hunk ↗ jump to hunk
+ =A0#endif /* CONFIG_COMPAT */ =A0#endif /* _LINUX_COMPAT_H */diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h index 1912c6c..3139f44 100644 --- a/include/linux/syscalls.h +++ b/include/linux/syscalls.h@@ -576,6 +576,8 @@ asmlinkage long sys_fstatat64(int dfd, char __user *f=
ilename,
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =
=A0 =A0 =A0 struct stat64 __user *statbuf, int flag);
=A0asmlinkage long sys_readlinkat(int dfd, const char __user *path, char =
__user *buf,
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =
=A0 =A0 =A0 int bufsiz);
+asmlinkage long sys_utimensat(int dfd, char __user *filename, +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0struct timespec __user *utimes, int flags);
=A0asmlinkage long compat_sys_futimesat(unsigned int dfd, char __user *fi=
lename,
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0 =A0 =A0 struct compat_timeval __user *t);
=A0asmlinkage long compat_sys_newfstatat(unsigned int dfd, char __user * =
filename, It seems bogus to declare compat_sys_futimesat in syscalls.h and compat_sys= _utimensat in compat.h. Your patch is fine, since there are precedents for both, but m= aybe we should agree on one place and then move all of the compat_sys_ declarati= ons there. Arnd <><