Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support

On Sun, May 06, 2007 at 03:04:14AM +0200, Segher Boessenkool wrote:

quoted

+		pcmcia@0080 {

quoted

+			#interrupt-cells = <1>;

quoted

+			interrupt-parent = <ff000000>;
+			interrupts = <d 1>;
+		};

Since this node's children's interrupt representation
is different from the node's parent's, you need an
interrupt-map in here.  You also forgot "#address-cells"
and I think you need "ranges" too?

And we should use a reference, instead of an implicit phandle for the
interrupt-parent.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson